-
Notifications
You must be signed in to change notification settings - Fork 28
Handle new APIML unique cookie identifier #996
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master zowe/imperative#996 +/- ##
==========================================
+ Coverage 89.73% 89.76% +0.03%
==========================================
Files 211 211
Lines 11471 11533 +62
Branches 2554 2584 +30
==========================================
+ Hits 10293 10353 +60
- Misses 1178 1180 +2
☔ View full report in Codecov by Sentry. |
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
… and viceversa Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
…le config-secure call Signed-off-by: zFernand0 <[email protected]>
…ady have a token Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
packages/imperative/src/config/cmd/auto-init/handlers/BaseAutoInitHandler.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: zFernand0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a request related to the text used in our prompts. However, I will accept whatever judgement call you make. Thus, I am approving this PR.
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
// Force the use of token value, in case user and/or password are also provided. | ||
if (params.arguments.tokenValue != null && | ||
(params.arguments.user != null || params.arguments.password != null)) { | ||
params.arguments.user = undefined; | ||
params.arguments.password = undefined; | ||
} | ||
|
||
params.arguments.tokenType = this.mDefaultTokenType; | ||
if (params.arguments.tokenType == null) { | ||
params.arguments.tokenType = this.mDefaultTokenType; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we handle removing certificates from the session as well? I guess this may not be a concern, if tokens have a higher priority than certificates when both are present 😅
will test with ZE before moving it to ready for review again 😋 |
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
…lient Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
…n as possible Signed-off-by: zFernand0 <[email protected]>
…we had the token already Signed-off-by: zFernand0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0 !
Signed-off-by: zFernand0 <[email protected]>
Signed-off-by: zFernand0 <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
add ImperativeExpect.toMatchRegExp
methodlogout
operations from failing due to not having a token availableautoStore
for dynamic APIML token typesallowedlogout
operation to remove token type and/or token value when either is not specified in the config filegetProfileNameFromPath
to help with nested token authenticationconfig secure
commandconsole.log
to inform which profile credentials are being prompted forauto-init
from performing twologin
operations on a single commandHow to Test
I recommend to combine this PR with the CLI counterpart:
Please see the above PR for testing instructions.
Review Checklist
I certify that I have:
Additional Comments
Opened issues as a result of this PR:
zowe config secure
does notautoStore
properties it prompts for zowe-cli#1866